Skip to content

Conversation

@Mnehmos
Copy link
Contributor

@Mnehmos Mnehmos commented Jun 10, 2025

PR for feature/4009-pr1-enable-partial-reads

Related GitHub Issue

Closes: #4009

Description

This pull request enables partial file reads by default, which improves performance by avoiding reading entire files when only a portion is needed. This is controlled by the enablePartialReads property in the promptOptions, which is now set to true by default.

Test Procedure

  1. Run existing tests to ensure no regressions.
  2. Manually test scenarios where partial file reads are expected.

Type of Change

  • ✨ New Feature: Non-breaking change that adds functionality.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A

Documentation Updates

None required.

Additional Notes

This is the first of three PRs to address the work in issue #4009.

@Mnehmos Mnehmos requested review from cte, jr and mrubens as code owners June 10, 2025 15:17
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@daniel-lxs
Copy link
Member

Hey @Mnehmos, there's a documented way to disable partial reads, by setting this option to -1:

image

For new installations partial reads are disabled, the change was introduced here #3936

Based on this I don't think it's a good idea to force partial reads to be enabled permanently.

I'll close this PR but feel free to continue the discussion, I would like to hear your thoughts.

@daniel-lxs daniel-lxs closed this Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 10, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

"Always read entire file" setting prevents line-range reads

2 participants